-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] web_sheet_full_width #2327
[16.0] [MIG] web_sheet_full_width #2327
Conversation
1d10f64
to
323f7ef
Compare
Not sure if we should pack all the moddings to the default responsive theme in one module:
@SplashS what do you think? Are you working on something? |
@pedrobaeza This module is still useful to use in conbination with EE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any chance to retrigger the runboat build |
Hi there Installed locally on an enterprise version. For a large width I get the same result as @tarteo, which is the standard way. But when you reduce the width so that the chatter is displayed below the sheet, the sheet takes all the width of the window. This is different from the standard. So functional test ok for me! Thanks for this pr. |
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
:alt: License: AGPL-3 | ||
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fweb-lightgray.png?logo=github | ||
:target: https://github.com/OCA/web/tree/15.0/web_sheet_full_width |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know when and how the 15.0 mentions will be replaced by 16.0, maybe when this is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know either. I'm going to check it in the case I missed to change it manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README.rst its generated again when is merged by oca-bot so that mentions to 15.0 will be replaced then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
runboat stucked, any chance to retrigger an event for testing on runboat |
@tarteo That behaviour with the chatter on the right is the default for large width. When web_chatter_position gets migrated this behaviour could be configured to show the chatter always on the bottom. I've just tried by removing the chatter manually in a large width:
|
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
- Add margin for better visibility - Add web_sheet_full_width migration state Done - Update to new OCA README.rst format.
[MIG] adapt web_sheet_full_width to V10.0 web framework
…renthesis in readme.
* less -> scss * fragment readme + add a pointer to web_responsive
More specifically, in web_enterprise the selector .o_form_view.o_xxl_form_view > .o_form_sheet_bg > .o_form_sheet fixes the width and has more specificity than this one
323f7ef
to
f336757
Compare
Functionally tested, LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review Ok
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 1db111e. Thanks a lot for contributing to OCA. ❤️ |
Migration of web_sheet_full_width to v16
#2309
Works as expected without other changes.